This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA 1/2 fix for bug with large structure offsets
- From: Joel Brobecker <brobecker at adacore dot com>
- To: David Taylor <dtaylor at usendtaylorx2l dot lss dot emc dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 15 Dec 2014 10:21:11 -0500
- Subject: Re: RFA 1/2 fix for bug with large structure offsets
- Authentication-results: sourceware.org; auth=none
- References: <18839 dot 1416329575 at usendtaylorx2l> <20141213132225 dot GC5457 at adacore dot com> <22812 dot 1418656160 at usendtaylorx2l>
> > resubmit them with a proper description of the problem they fix and
> > a ChangeLog entry? Please Cc: me and I will review them next weekend.
>
> Is the description and ChangeLog in part 0 insufficient?
>
> There were three parts --
>
> 0/2 -- description of the problem and ChangeLog entries
> 1/2 -- changes to GDB proper
> 2/2 -- testsuite changes (basically, a really simple test)
The introduction email is good sometimes, but now try to include
all the necessary info to explain what the patch does in the
commit's revision log. There are two advantages to this:
1. It makes archeology a lot easier, since the information
is right there;
2. It makes it easier for you to contribute the patch, since
all you have to do is git-email it.
Introduction emails are useful sometimes when you want to provide
some general context that doesn't really belong in the revision
log of any of the patches. The idea is that we should be able to
have all necessary info for a given commit just by looking at
that commit.
Remember to Cc: me when you resubmit - it'll help me remember
I promised to review your patches this weekend.
--
Joel