This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Rename cp_is_anonymous to cp_is_in_anonymous
- From: Doug Evans <xdje42 at gmail dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Sat, 13 Dec 2014 10:36:19 -0800
- Subject: Re: [PATCH] Rename cp_is_anonymous to cp_is_in_anonymous
- Authentication-results: sourceware.org; auth=none
- References: <m3fvcn4cjz dot fsf at sspiff dot org>
On Wed, Dec 10, 2014 at 9:52 AM, Doug Evans <xdje42@gmail.com> wrote:
> Hi.
>
> cp-namespace.c has a lot of readability issues.
> In the produces of doing bigger cleanups and speedups,
> I'd like to make cp-namespace.c more readable.
>
> This is a small step in that direction.
> [I have more to come, but where they are independent of each other
> I'm keeping them separate.]
> When I read "cp_is_anonymous" I think
> strcmp (name, CP_ANONYMOUS_NAMESPACE_STR),
> not strstr (name, CP_ANONYMOUS_NAMESPACE_STR).
>
> One could also make cp_is_in_anonymous static, but it's a nice
> general API-like routine, so I'm leaving it public.
> [And at any rate making it static could be a separate patch.]
>
> 2014-12-10 Doug Evans <xdje42@gmail.com>
>
> * cp-support.h (cp_is_in_anonymous): Renamed from cp_is_anonymous.
> All callers updated. Rename arg "namesapce" to "symbol_name".
Committed.