This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] Function attributes: use shorter versions of the format macros
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Cleber Rosa <crosa at redhat dot com>
- Cc: gdb-patches at sourceware dot org, cleber at redhat dot com
- Date: Wed, 3 Dec 2014 14:31:11 +0400
- Subject: Re: [PATCH 2/2] Function attributes: use shorter versions of the format macros
- Authentication-results: sourceware.org; auth=none
- References: <1417449499-23681-1-git-send-email-crosa at redhat dot com> <1417449499-23681-2-git-send-email-crosa at redhat dot com>
> For consistency sake, use the shorter versions of the function attribute
> format macros.
Same as in patch #1, please include the ChangeLog entry in the
commit's revision log.
It would be good also to explain in the revision log consistency
with what, becuase GDB uses nearly exclusively the form that you
are removing. I know the answer, now, but it took me some time to
figure it out.
> +2014-12-01 Cleber Rosa <cleber@redhat.com>
> +
> + * ada-lang.c: use shorter versions of function attributes macros.
> + * cli-out.c: Likewise.
> + * common/agent.c: Likewise.
> + * common/buffer.h: Likewise.
> + * common/common-debug.h: Likewise.
> + * common/common-exceptions.h: Likewise.
> + * common/common-utils.h: Likewise.
> + * common/errors.h: Likewise.
> + * complaints.h: Likewise.
> + * disasm.c: Likewise.
> + * exceptions.h: Likewise.
> + * language.h: Likewise.
> + * monitor.c: Likewise.
> + * parser-defs.h: Likewise.
> + * serial.h: Likewise.
> + * ui-out.h: Likewise.
> + * utils.h: Likewise.
Approved.
Thank you,
--
Joel