This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Don't enable gdbtk in testsuite
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 30 Nov 2014 19:23:39 +0400
- Subject: Re: [PATCH] Don't enable gdbtk in testsuite
- Authentication-results: sourceware.org; auth=none
- References: <1416903049-30419-1-git-send-email-yao at codesourcery dot com>
> When I skim configure.ac and Makefile.in in gdb/testsuite, I happen to
> see that directory gdb.gdbtk is added to subdirs, however it doesn't
> exist. gdb/testsuite/gdb.gdbtk was removed by the patch below,
>
> [rfa] git repo fixup: delete gdb/testsuite/gdb.gdbtk
> http://thread.gmane.org/gmane.comp.gdb.patches/61489
>
> and we should cleanup configure.ac accordingly.
>
> gdb/testsuite:
>
> 2014-11-25 Yao Qi <yao@codesourcery.com>
>
> * configure.ac: Remove AC_ARG_ENABLE for gdbtk. Don't invoke
> AC_CONFIG_SUBDIRS(gdb.gdbtk).
> * configure: Re-generated.
FWIW, the patch looks good to me, so you can go ahead and push.
--
Joel