This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] frame.c: Fix the check for FID_STACK_INVALID in frame_id_eq().
- From: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- To: gdb-patches at sourceware dot org
- Cc: daniel dot gutson at tallertechnologies dot com
- Date: Tue, 25 Nov 2014 16:34:48 -0300
- Subject: [PATCH] frame.c: Fix the check for FID_STACK_INVALID in frame_id_eq().
- Authentication-results: sourceware.org; auth=none
I noticed in frame_id_eq() we were checking for the "l" frame_id being invalid twice instead of checking both "l" and "r", so I corrected it.
gdb/ChangeLog:
2014-11-25 Martin Galvan <martin.galvan@tallertechnologies.com>
* frame.c (frame_id_eq): Fix the check for FID_STACK_INVALID.
---
diff --git a/gdb/frame.c b/gdb/frame.c
index 0663af9..135b820 100644
--- a/gdb/frame.c
+++ b/gdb/frame.c
@@ -614,7 +614,7 @@ frame_id_eq (struct frame_id l, struct frame_id r)
outer_frame_id. */
eq = 1;
else if (l.stack_status == FID_STACK_INVALID
- || l.stack_status == FID_STACK_INVALID)
+ || r.stack_status == FID_STACK_INVALID)
/* Like a NaN, if either ID is invalid, the result is false.
Note that a frame ID is invalid iff it is the null frame ID. */
eq = 0;