This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH] Fix MPX and AVX512 tests for path changes.
- From: "Tedeschi, Walfred" <walfred dot tedeschi at intel dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: "palves at redhat dot com" <palves at redhat dot com>, "mark dot kettenis at xs4all dot nl" <mark dot kettenis at xs4all dot nl>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 24 Nov 2014 13:48:18 +0000
- Subject: RE: [PATCH] Fix MPX and AVX512 tests for path changes.
- Authentication-results: sourceware.org; auth=none
- References: <1412062097-22417-1-git-send-email-walfred dot tedeschi at intel dot com> <20141123034212 dot GB5774 at adacore dot com>
Hello Joel,
Thanks a lot for your review!
Ok! I will proceed as you proposed!
Best regards,
-Fred
-----Original Message-----
From: Joel Brobecker [mailto:brobecker@adacore.com]
Sent: Sunday, November 23, 2014 4:42 AM
To: Tedeschi, Walfred
Cc: palves@redhat.com; mark.kettenis@xs4all.nl; gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix MPX and AVX512 tests for path changes.
Hello Walfred,
On Tue, Sep 30, 2014 at 09:28:17AM +0200, Walfred Tedeschi wrote:
> Changes on the path for i386-cpuid.h file lead to failure in compiling
> tests for MPX and AVX512. Conformity between both tests is also
> addressed with this path.
>
> 2014-08-12 Walfred Tedeschi <walfred.tedeschi@intel.com>
>
> gdb/testsuite
> * gdb.arch/i386-avx512.c: Change path in include file.
> * gdb.arch/i386-mpx.c: Change path in include file.
> * gdb.arch/i386-avx512.exp: Change include dir path
> compilation flag.
> * gdb.arch/i386-mpx.exp: Change include dir path
> compilation flag.
Overall, the changes look good. But would you mind please splitting this patch into individual pieces. For instance, one patch to fix i386-avx512.exp's build failure, one patch to fix i386-mpx.exp's build failure, and then as many individual patches for the other changes made for "conformity between both tests". I am 300 patches behind on review and trying to spend this weekend catching up a bit, so a more detailed explanation will help me, as well as anyone going back in time trying to figure out why some changes were made.
Thank you!
--
Joel
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052