This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v5] Make chained function calls in expressions work
- From: Siva Chandra <sivachandra at google dot com>
- To: gdb-patches <gdb-patches at sourceware dot org>
- Cc: Ulrich Weigand <uweigand at de dot ibm dot com>
- Date: Mon, 24 Nov 2014 00:23:43 -0800
- Subject: Re: [PATCH v5] Make chained function calls in expressions work
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gy5aqsQ++nvAT7E1nqHvyz5YTeCen7tLwGY2GURqaT_tw at mail dot gmail dot com>
On Sun, Nov 16, 2014 at 10:08 PM, Siva Chandra <sivachandra@google.com> wrote:
> Link to v4: https://sourceware.org/ml/gdb-patches/2014-10/msg00697.html
>
> I have made all the changes suggested by Ulrich Weigand in his comments for v4.
>
> gdb/ChangeLog:
>
> 2014-11-16 Siva Chandra Reddy <sivachandra@google.com>
>
> * eval.c: Include gdbthread.h.
> (evaluate_subexp): Enable thread stack temporaries before
> evaluating a complete expression and clean them up after the
> evaluation is complete.
> * gdbthread.h: Include common/vec.h.
> (value_ptr): New typedef.
> (VEC (value_ptr)): New vector type.
> (value_vec): New typedef.
> (struct thread_info): Add new fields stack_temporaries_enabled
> and stack_temporaries.
> (enable_thread_stack_temporaries)
> (thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
> (skip_thread_stack_temporaries)
> (value_in_thread_stack_temporaries): Declare.
> * gdbtypes.c (class_or_union_p): New function.
> * gdbtypes.h (class_or_union_p): Declare.
> * infcall.c (get_return_value_from_memory): New function.
> (call_function_by_hand): Store return values of class type as
> temporaries on stack.
> * thread.c (enable_thread_stack_temporaries): New function.
> (thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
> (skip_thread_stack_temporaries): Likewise.
> (value_in_thread_stack_temporaries): Likewise.
> (struct ptid_data): New type.
> * value.c (value_force_lval): New function.
> * value.h (value_force_lval): Declare.
>
> gdb/testsuite/ChangeLog:
>
> 2014-11-16 Siva Chandra Reddy <sivachandra@google.com>
>
> * gdb.cp/chained-calls.cc: New file.
> * gdb.cp/chained-calls.exp: New file.
> * gdb.cp/smartp.exp: Remove KFAIL for "p c2->inta".
Ping.