This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] gdb/hppa-tdep.c: Fix logical working flow typo issue
- From: Chen Gang <gang dot chen dot 5i5j at gmail dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org, Andreas Schwab <schwab at suse dot de>
- Date: Sun, 23 Nov 2014 21:40:37 +0800
- Subject: Re: [PATCH v2] gdb/hppa-tdep.c: Fix logical working flow typo issue
- Authentication-results: sourceware.org; auth=none
- References: <5447CF8A dot 6020603 at gmail dot com> <544AD714 dot 8040506 at gmail dot com> <20141123063849 dot GA7636 at adacore dot com>
On 11/23/2014 02:38 PM, Joel Brobecker wrote:
> Chen,
>
>> Is this patch OK, it is part of checking saving registers in the stack,
>> it tries to recognize the saving instructions "stb, stw(m), or std", so
>> can continue checking.
>>
>> Excuse me, I have no related environments for a test, I assumed that the
>> original author knew about the working flow, then wrote the related
>> function.
>>
>> If need additional analyzing, please let me know (better to let me know
>> what I need try, next).
>
> Thank you for the patch, but lack of access to an environment where
> you can test is an issue. I would be an entirely different context
> if the fix was obvious, but it isn't unless perhaps you start
> opening HP-PA assembly manuals; and I don't honestly see much interest
> in HP-PA anymore.
>
I shall try to find the related assembly reference (although it is not
quite easy for me, and may be fail to get it), or get parisc related
members confirmation.
Hope I can get related proof (related documents, or related members
confirmation) within next month (2014-12-31), although I am not quite
sure whether I can finish or not.
> And if you do not have access to an environment for a test, how did
> you come about this issue? Does the lack of evironment mean lack of
> the software (tcl, expect, dejagnu), or lack of hardware?
>
It is lack of hardware and related software. And I found it firstly by
gcc5 compiler warning, then read through the code (together with some
gdb members), found it should be an issue.
Thanks.
--
Chen Gang
Open share and attitude like air water and life which God blessed