This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add gdbarch_sizeof_g_packet to "struct remote_arch_state" to handle the issue that get error "Remote 'g' packet reply is too long" with qemu-system-x86_64
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Hui Zhu <teawater at gmail dot com>
- Cc: Doug Evans <xdje42 at gmail dot com>, gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Mon, 17 Nov 2014 14:25:18 +0400
- Subject: Re: [PATCH] Add gdbarch_sizeof_g_packet to "struct remote_arch_state" to handle the issue that get error "Remote 'g' packet reply is too long" with qemu-system-x86_64
- Authentication-results: sourceware.org; auth=none
- References: <1409238683-17886-1-git-send-email-teawater at gmail dot com> <CANFwon2rZ0LzY_FCr8BDPFZhx_qBxm8qG6NCfWuz3He717pHCQ at mail dot gmail dot com> <CANFwon1Yfj2AEDdDrivfdh1Gi0DH_n1KBhNV5vtvkfaRwUDDRg at mail dot gmail dot com> <CAP9bCMQOs6Mw94V8LfrdDt_rxSN7MMap=DoRDL6cPAd+8ATjGg at mail dot gmail dot com> <CANFwon2mnb85tdGJHU=QNaHrHDi0Qv_GGM0ZHD4_G4DBOxe2Og at mail dot gmail dot com>
> Will GDB be hurted if it support bigger size? Maybe GDB can output a
> warning like "the size that you use is bigger than xxxxxx", And keep
> work.
> But not just tell the user "your target is cheater. It changed the
> size. I hate that. I will not work with it."
> GDB is a debugger but not a judge, right?
Yes, GDB will be hurt if we try applying bandaids for issues
we don't understand. One bandaid doesn't seem like much, but
they accumulate over time, and make long-term maintenance
a lot harder.
We need to understand what is going on before we can determine
whether the fix you are proposing is the best approach.
--
Joel