This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] microMIPS support (Linux signal trampolines)
- From: Joel Brobecker <brobecker at adacore dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org, Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Date: Sun, 16 Nov 2014 12:58:01 +0400
- Subject: Re: [PATCH] microMIPS support (Linux signal trampolines)
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 1 dot 10 dot 1204241843340 dot 19835 at tp dot orcam dot me dot uk> <alpine dot DEB dot 1 dot 10 dot 1205171611090 dot 11227 at tp dot orcam dot me dot uk> <201205182225 dot q4IMPBiD031110 at glazunov dot sibelius dot xs4all dot nl> <alpine dot DEB dot 1 dot 10 dot 1205182329550 dot 11227 at tp dot orcam dot me dot uk> <alpine dot DEB dot 1 dot 10 dot 1409280051430 dot 4971 at tp dot orcam dot me dot uk>
> I'd like to get back to this change and review. Here's the same code
> regenerated against current trunk. Can we please get consensus on changes
> to tramp-frame.[ch]?
[...]
> 2014-09-28 Maciej W. Rozycki <macro@codesourcery.com>
>
> gdb/
> * tramp-frame.h (tramp_frame): Add validate member.
> * tramp-frame.c (tramp_frame_start): Validate trampoline before
> scanning.
> * mips-linux-tdep.c (MICROMIPS_INST_LI_V0): New macro.
> (MICROMIPS_INST_POOL32A, MICROMIPS_INST_SYSCALL): Likewise.
> (mips_linux_o32_sigframe): Initialize validate member.
> (mips_linux_o32_rt_sigframe): Likewise.
> (mips_linux_n32_rt_sigframe): Likewise.
> (mips_linux_n64_rt_sigframe): Likewise.
> (micromips_linux_o32_sigframe): New variable.
> (micromips_linux_o32_rt_sigframe): Likewise.
> (micromips_linux_n32_rt_sigframe): Likewise.
> (micromips_linux_n64_rt_sigframe): Likewise.
> (mips_linux_o32_sigframe_init): Handle microMIPS trampolines.
> (mips_linux_n32n64_sigframe_init): Likewise.
> (mips_linux_sigframe_validate): New function.
> (micromips_linux_sigframe_validate): Likewise.
> (mips_linux_init_abi): Install microMIPS trampoline unwinders.
Sorry again for the late review, Maciej.
This patch is pre-approved, with one tiny little request:
Can you add a quick one-liner comment as documentation for
all the new functions? For instance:
/* Implement struct tramp_frame's "validate" method for [...] */
static int
mips_linux_sigframe_validate (const struct tramp_frame *self,
Thank you!
--
Joel