This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] dwarf.exp: In 64-bit units, emit also abbrev offset as a 64-bit field
- From: Yao Qi <yao at codesourcery dot com>
- To: Petr Machata <pmachata at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Sat, 15 Nov 2014 17:02:24 +0800
- Subject: Re: [PATCH] dwarf.exp: In 64-bit units, emit also abbrev offset as a 64-bit field
- Authentication-results: sourceware.org; auth=none
- References: <m2egt6h8xo dot fsf at redhat dot com>
Petr Machata <pmachata@redhat.com> writes:
> I don't have commit priviliges, so if this patch is acceptable, I'll
> need someone else to commit this for me.
The patch looks good to me.
> diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
> index 1edfc93..7f714a9 100644
> --- a/gdb/testsuite/ChangeLog
> +++ b/gdb/testsuite/ChangeLog
> @@ -1,3 +1,8 @@
> +2014-11-14 Petr Machata <pmachata@redhat.com>
> +
> + * lib/dwarf.exp (Dwarf::cu, Dwarf::tu): In units with 64-bit
> + offsets, emit also abbrev offset as a 64-bit field.
Your changelog entry doesn't describe what the change is. How about this?
* lib/dwarf.exp (Dwarf::cu, Dwarf::tu): Emit
${_cu_offset_size} bytes abbrev offset.
I'll commit the patch for you if you are happy with the updated changelog.
--
Yao (éå)