This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v4] Make chained function calls in expressions work
- From: Siva Chandra <sivachandra at google dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Tue, 4 Nov 2014 07:23:33 -0800
- Subject: Re: [PATCH v4] Make chained function calls in expressions work
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gzmjJYTYfSmZi9qArdpKVu-vtkP7wG0dNjPPMboyp6fHg at mail dot gmail dot com> <201411041458 dot sA4EwuJT001432 at d06av02 dot portsmouth dot uk dot ibm dot com>
On Tue, Nov 4, 2014 at 6:58 AM, Ulrich Weigand <uweigand@de.ibm.com> wrote:
> Siva Chandra wrote:
>> On Tue, Nov 4, 2014 at 5:38 AM, Ulrich Weigand <uweigand@de.ibm.com> wrote:
>> > Yes, having an additional flag in struct expression would fix the safety
>> > issue. Moving initialization to evalute_subexp if *pos == 0 would then
>> > no longer be safety issue, but simply enabling use of temporaries in more
>> > cases.
>>
>> Since I have my code already setup in this fashion, I would prefer to
>> go this route unless you see an advantage of going with the solution
>> you suggest below.
>
> Well, I don't think there are any functional advantages as such, but the
> implementation looks a bit cleaner (all the details of temporary handling
> done in infcall.c; fewer interactions between eval.c and infcall.c;
> shorter patch overall).
Shall I go with the thread route then?