This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 12/13 v2] Move low-level Linux x86 debug register code to a shared file
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>, gdb-patches at sourceware dot org
- Date: Tue, 28 Oct 2014 13:01:29 +0000
- Subject: Re: [PATCH 12/13 v2] Move low-level Linux x86 debug register code to a shared file
- Authentication-results: sourceware.org; auth=none
- References: <1412848358-9958-1-git-send-email-gbenson at redhat dot com> <1412848358-9958-13-git-send-email-gbenson at redhat dot com>
On 10/09/2014 10:52 AM, Gary Benson wrote:
> diff --git a/gdb/nat/x86-linux-dregs.c b/gdb/nat/x86-linux-dregs.c
> new file mode 100644
> index 0000000..3e3d876
> --- /dev/null
> +++ b/gdb/nat/x86-linux-dregs.c
> @@ -0,0 +1,173 @@
> +/* Low-level debug register code for x86 (i386 and x86-64).
I think this comment should mention "Linux" too.
> +++ b/gdb/nat/x86-linux-dregs.h
> @@ -0,0 +1,53 @@
> +/* Low-level debug register code for x86 (i386 and x86-64).
Likewise.
Otherwise OK.
Thanks,
Pedro Alves