This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Remove non-address bits for longjmp resume breakpoint
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: arnez at linux dot vnet dot ibm dot com (Andreas Arnez)
- Cc: gdb-patches at sourceware dot org, stli at linux dot vnet dot ibm dot com (Stefan Liebler)
- Date: Tue, 14 Oct 2014 13:59:25 +0200 (CEST)
- Subject: Re: [PATCH] Remove non-address bits for longjmp resume breakpoint
- Authentication-results: sourceware.org; auth=none
Andreas Arnez wrote:
> On 32-bit S390 targets the longjmp target address "naturally" has the
> most significant bit set. That bit indicates the addressing mode and
> is not part of the address itself. Thus, in analogy with similar
> cases (like when computing the caller PC in
> insert_step_resume_breakpoint_at_caller), this change removes
> non-address bits from the longjmp target address before using it as a
> breakpoint address.
Makes sense.
> * gdb/infrun.c (process_event_stop_test): Apply
> gdbarch_addr_bits_remove to longjmp resume address.
This is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com