This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH V2 3/9] New commands `enable probe' and `disable probe'.
- From: Eli Zaretskii <eliz at gnu dot org>
- To: "Jose E. Marchesi" <jose dot marchesi at oracle dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 10 Oct 2014 21:15:32 +0300
- Subject: Re: [PATCH V2 3/9] New commands `enable probe' and `disable probe'.
- Authentication-results: sourceware.org; auth=none
- References: <1412961772-16249-1-git-send-email-jose dot marchesi at oracle dot com> <1412961772-16249-4-git-send-email-jose dot marchesi at oracle dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
> Date: Fri, 10 Oct 2014 19:22:46 +0200
>
> +Some probe points can be enabled and/or disabled. The effects
> +associated to enabling or disabling a probe depend on the type of
Just "the effect of enabling or disabling a probe" is enough, and much
more clear.
> +probe being handled. @code{SystemTap} probes do not support these
^^
Two spaces between sentences.
Also, I think we agreed to say SystemTap probes cannot be disabled.
> +@item enable probes @r{[}@var{provider} @r{[}@var{name} @r{[}@var{objfile}@r{]}@r{]}@r{]}
> +If given, @var{provider} is a regular expression used to match against
> +provider names when selecting which probes to enable. If omitted,
> +probes by all probes from all providers are enabled.
"Probes by all probes"? Something is wrong here.
Thanks.