This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/9] Move `compute_probe_arg' and `compile_probe_arg' to probe.c
- From: jose dot marchesi at oracle dot com (Jose E. Marchesi)
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 10 Oct 2014 18:37:34 +0200
- Subject: Re: [PATCH 2/9] Move `compute_probe_arg' and `compile_probe_arg' to probe.c
- Authentication-results: sourceware.org; auth=none
- References: <1411724905-31234-1-git-send-email-jose dot marchesi at oracle dot com> <1411724905-31234-3-git-send-email-jose dot marchesi at oracle dot com> <87tx3q6km3 dot fsf at redhat dot com>
> This patch moves the `compute_probe_arg' and `compile_probe_arg' functions
> from stap-probe.c to probe.c. The rationale is that it is reasonable to
> assume that all backends will provide the `$_probe_argN' convenience
> variables, and that the user must be placed on the PC of the probe when
> requesting that information. The value and type of the argument can still be
> determined by the probe backend via the `pops->evaluate_probe_argument' and
> `pops->compile_to_ax' handlers.
>
> Note that a test in gdb.base/stap-probe.exp had to be adjusted because the "No
> SystemTap probe at PC" messages are now "No probe at PC".
Hi Jose,
Thanks for this patch.
Just a nit on the ChangeLog entry.
Fixed in the patch.