This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] Fix non-stop regressions caused by "breakpoints always-inserted off" changes
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 10 Oct 2014 13:52:50 +0100
- Subject: Re: [PATCH 3/3] Fix non-stop regressions caused by "breakpoints always-inserted off" changes
- Authentication-results: sourceware.org; auth=none
- References: <1411657123-16228-1-git-send-email-palves at redhat dot com> <1411657123-16228-4-git-send-email-palves at redhat dot com> <87fveyu7db dot fsf at codesourcery dot com>
On 10/08/2014 12:29 PM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> - if (signal_print[ecs->event_thread->suspend.stop_signal])
>> - {
>> - /* The signal table tells us to print about this signal. */
>> - printed = 1;
>> - target_terminal_ours_for_output ();
>> - observer_notify_signal_received (ecs->event_thread->suspend.stop_signal);
>> - }
>> /* Always stop on signals if we're either just gaining control
>> of the program, or the user explicitly requested this thread
>> to remain stopped. */
>> @@ -4214,10 +4207,17 @@ handle_signal_stop (struct execution_control_state *ecs)
>> stop_waiting (ecs);
>> return;
>> }
>> - /* If not going to stop, give terminal back
>> - if we took it away. */
>> - else if (printed)
>
> The use of local variable 'printed' is removed by this patch. We can
> remove 'printed' too, as the patch below does. It is obvious, and I'll
> push it in.
Thanks Yao.
Thanks,
Pedro Alves