This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] Fix non-stop regressions caused by "breakpoints always-inserted off" changes
- From: Yao Qi <yao at codesourcery dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 8 Oct 2014 18:55:39 +0800
- Subject: Re: [PATCH 3/3] Fix non-stop regressions caused by "breakpoints always-inserted off" changes
- Authentication-results: sourceware.org; auth=none
- References: <1411657123-16228-1-git-send-email-palves at redhat dot com> <1411657123-16228-4-git-send-email-palves at redhat dot com>
Pedro Alves <palves@redhat.com> writes:
[ThunderBird puts this series into a wrong thread, so I don't see it
until today]
The patch looks reasonable to me.
> - /* Don't print a message if in the middle of doing a "step n"
> - operation for n > 1 */
> + /* Notify observers if we finished a "step"-like command, etc. */
> if (target_has_execution
> && last.kind != TARGET_WAITKIND_SIGNALLED
> && last.kind != TARGET_WAITKIND_EXITED
> - && inferior_thread ()->step_multi
> && inferior_thread ()->control.stop_step)
> - goto done;
> + {
> + /* But not if if in the middle of doing a "step n" operation for
^^^^^
Duplicated "if"?
--
Yao (éå)