This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/9] New commands `enable probe' and `disable probe'.
- From: jose dot marchesi at oracle dot com (Jose E. Marchesi)
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 29 Sep 2014 12:11:24 +0200
- Subject: Re: [PATCH 3/9] New commands `enable probe' and `disable probe'.
- Authentication-results: sourceware.org; auth=none
- References: <no at [87 dot 69 dot 4 dot 28]> <1411724905-31234-1-git-send-email-jose dot marchesi at oracle dot com> <1411724905-31234-4-git-send-email-jose dot marchesi at oracle dot com> <83r3yyttlf dot fsf at gnu dot org>
Hi Eli, thanks for your review.
> +@kindex enable probes
> +@item enable probes @r{[}@var{provider} @r{[}@var{name} @r{[}@var{objfile}@r{]}@r{]}@r{]}
Is it correct that NAME can be given only if PROVIDER is given, and
OBJFILE can be given only if both NAME and PROVIDER were given?
That's what the nesting of [..] suggests.
Yes, that is correct. The same syntax is used in the `info probes'
command, so I just kept it.
> +Each argument is a regular expression, used to select probes.\n\
> +PROVIDER matches probe provider names.\n\
> +NAME matches the probe names.\n\
> +OBJECT matches the executable or shared library name.\n\
> +If you do not specify any argument then the command will disable\n\
> +all defined probes."), ^^^^^^^^
A copy/paste typo.
Fixed, thanks.