This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Don't prune program spaces when doing "maintenance info program-spaces"
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>, Doug Evans <dje at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 25 Sep 2014 10:44:34 -0400
- Subject: Re: [PATCH] Don't prune program spaces when doing "maintenance info program-spaces"
- Authentication-results: sourceware.org; auth=none
- References: <1411582288-20967-1-git-send-email-simon dot marchi at ericsson dot com> <CADPb22StC=Lg8a=ZkxuVZ-a0g_-oa+BdOrvB=jj9=cEQYGhEgg at mail dot gmail dot com> <87sijgig81 dot fsf at redhat dot com>
On 2014-09-24 10:30 PM, Sergio Durigan Junior wrote:
> On Wednesday, September 24 2014, Doug Evans wrote:
>
>> IOW, how about move the call to prune_program_spaces to whatever
>> caller wants it.
>
> As a note, after I commented on the patch, I noticed that the "prune"
> argument may be unecessary indeed (and the "prunning" logic"), because
> we are not prunning anything anymore.
>
> Anyway, I just wanted to say that I agree with removing this part of the
> code, and moving it to more suitable parts.
Fine with me. Here is the updated patch, much simpler now.
gdb/Changelog:
* progspace.c (print_program_space): Don't prune program spaces
before printing them.
---
gdb/progspace.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/gdb/progspace.c b/gdb/progspace.c
index a74b6ab..b111a50 100644
--- a/gdb/progspace.c
+++ b/gdb/progspace.c
@@ -281,10 +281,6 @@ print_program_space (struct ui_out *uiout, int requested)
int count = 0;
struct cleanup *old_chain;
- /* Might as well prune away unneeded ones, so the user doesn't even
- seem them. */
- prune_program_spaces ();
-
/* Compute number of pspaces we will print. */
ALL_PSPACES (pspace)
{
--
2.1.0