This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- From: Doug Evans <dje at google dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Gary Benson <gbenson at redhat dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Fri, 19 Sep 2014 14:47:44 -0600
- Subject: Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Authentication-results: sourceware.org; auth=none
- References: <21520 dot 36381 dot 756875 dot 963606 at ruffy2 dot mtv dot corp dot google dot com> <20140911102659 dot GA17472 at blade dot nx> <5412DEB5 dot 6020706 at redhat dot com> <21523 dot 9502 dot 168492 dot 803068 at ruffy2 dot mtv dot corp dot google dot com> <54132B55 dot 9000108 at redhat dot com> <21523 dot 12189 dot 134570 dot 770432 at ruffy2 dot mtv dot corp dot google dot com> <5413305B dot 6020402 at redhat dot com> <21523 dot 13993 dot 986533 dot 615240 at ruffy2 dot mtv dot corp dot google dot com> <54133939 dot 70801 at redhat dot com> <CADPb22RsGv_Do1SztOK4Bse99e5yL_hmnrOHCU8OhNGkFyxGDQ at mail dot gmail dot com> <20140915100736 dot GA13503 at blade dot nx> <CADPb22Qs-Xi7DV+8OV32ao8KUw6OB-8F3wbKB3+Fypd7Rjd64A at mail dot gmail dot com> <54181295 dot 6030302 at redhat dot com> <CADPb22R04_aBC+B8yO=cdvYnxn1Yk_0mNtPEMqksGROnMiGi5g at mail dot gmail dot com> <541970D8 dot 3080504 at redhat dot com> <CADPb22QXZRr5yMCT7h8ydJKOn6wKUH5sR5DJBC_4imY6a_FGRA at mail dot gmail dot com> <541C50DF dot 6030105 at redhat dot com>
On Fri, Sep 19, 2014 at 9:50 AM, Pedro Alves <palves@redhat.com> wrote:
> On 09/17/2014 07:20 PM, Doug Evans wrote:
>
>>>> I thought about target_resume. It was an semi-interesting case
>>>> that immediately popped into my head at the time.
>>>> And then I tried to think how the typical reader would interpret it.
>>>> I'm not a typical reader, but I think(!) people would expect it to be
>>>> asynchronous in the sense that the inferior is resumed and
>>>> control returns to gdb. IOW target_resume doesn't also wait
>>>> for the inferior to stop after it has been resumed.
>>>> Therefore I see no need to rename it (say to target_resume_no_wait).
>
> OK. I was reading it like "a convention where all async functions
> ended with _async or _no_wait" would be applied throughout. I could
> see instead that restricted to cases where we have two variants -- I
> guess that's where my understanding was.
I did write "... that is otherwise ambiguous".
ref: https://sourceware.org/ml/gdb-patches/2014-09/msg00440.html
- References:
- Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid