This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] New "producer" attribute for gdb.Symtab objects
- From: Pedro Alves <palves at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org, eliz at gnu dot org
- Date: Thu, 18 Sep 2014 10:38:57 +0100
- Subject: Re: [PATCH] New "producer" attribute for gdb.Symtab objects
- Authentication-results: sourceware.org; auth=none
- References: <yjt2ppevf8il dot fsf at ruffy dot mtv dot corp dot google dot com> <5418D665 dot 5090309 at redhat dot com> <21530 dot 11079 dot 11868 dot 273521 at ruffy2 dot mtv dot corp dot google dot com>
On 09/18/2014 01:45 AM, Doug Evans wrote:
> Pedro Alves writes:
> > On 09/17/2014 12:30 AM, Doug Evans wrote:
> > > +# We can't do much to test the producer string (compiler name+version).
> >
> > Sounds like a job for the testsuite's dwarf compiler.
>
> Indeed.
Nice, this looks good to me. Thanks.
> + } {
> + declare_labels integer_label
> +
> + integer_label: DW_TAG_base_type {
> + {DW_AT_byte_size 4 DW_FORM_sdata}
> + {DW_AT_encoding @DW_ATE_signed}
> + {DW_AT_name integer}
> + }
> +
Something odd with indentation here (and likewise
in the other CU). Looks like tabs vs spaces.
> + DW_TAG_variable {
> + {DW_AT_name with_producer}
> + {DW_AT_type :$integer_label}
> + {DW_AT_external 1 flag}
> + {DW_AT_const_value 42 DW_FORM_sdata}
> + }
Thanks,
Pedro Alves