This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [Patch, microblaze] Add little-endian breakpoint



-----Original Message-----
From: Michael Eager [mailto:eager@eagercon.com] 
Sent: Thursday, July 24, 2014 12:10 AM
To: Ajit Kumar Agarwal; gdb-patches@sourceware.org
Cc: Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala
Subject: Re: [Patch, microblaze] Add little-endian breakpoint

On 06/16/14 12:02, Ajit Kumar Agarwal wrote:
> Hello All:
>
> The following Patch add the little-endian breakpoint.
>
>   [Patch,microblaze] Add little-endian breakpoint
>
>      Add little-endian breakpoint.
>
>      ChangeLog:
>      2014-06-16 Ajit Agarwal <ajitkum@xilinx.com>
>
>          * microblaze-tdep.c (microblaze_breakpoint_from_pc): Use
>          of gdbarch_byte_order. Initialize break_insn_le to
>          MICROBLAZE_BREAKPOINT_LE. Check byte_order with
>          BFD_ENDIAN_BIG.
>
>          * microblaze-tdep.h (MICROBLAZE_BREAKPOINT_LE): New Macro.
>
>      Signed-off-by:Ajit Agarwal ajitkum@xilinx.com

>>Please update this patch to add a test case to the gdb test suite.

The existing gdb testsuite if compiled and tested with little endian binaries will fail.
Hence the existing testsuite is sufficient and we donât see a need for a new testcase.
 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]