This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- From: Pedro Alves <palves at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: Gary Benson <gbenson at redhat dot com>, gdb-patches at sourceware dot org
- Date: Fri, 12 Sep 2014 18:41:47 +0100
- Subject: Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Authentication-results: sourceware.org; auth=none
- References: <1409320299-6812-1-git-send-email-gbenson at redhat dot com> <1409320299-6812-4-git-send-email-gbenson at redhat dot com> <21520 dot 36381 dot 756875 dot 963606 at ruffy2 dot mtv dot corp dot google dot com> <20140911102659 dot GA17472 at blade dot nx> <5412DEB5 dot 6020706 at redhat dot com> <21523 dot 9502 dot 168492 dot 803068 at ruffy2 dot mtv dot corp dot google dot com> <54132B55 dot 9000108 at redhat dot com> <21523 dot 12189 dot 134570 dot 770432 at ruffy2 dot mtv dot corp dot google dot com>
On 09/12/2014 06:38 PM, Doug Evans wrote:
> Pedro Alves writes:
> > On 09/12/2014 05:53 PM, Doug Evans wrote:
> >
> > > That may be sufficient for me to make this patch checkin-able,
> > > but before then I'd like to understand how and where
> > > this function will be used from gdb.
> >
> > Can you clarify? I don't have any plan to use this
> > elsewhere myself. All we're doing is factoring out
> > the current use behind a common function so that both gdb
> > and gdbserver can implement it their own way.
>
> I don't see the function being used in gdb by this patch set.
> So, absent further info, the change to gdb/target.c is just adding
> dead code. I'm assuming that's not the case (*1), but until I
> understand how it's going to be used in gdb it's not clear to
> me whether code that uses it will be confusing to read.
It's used in common/agent.c, which is used by gdb as well.
linux-nat.c: agent_run_command (pid, s, strlen (s) + 1);
linux-nat.c: agent_run_command (pid, s, strlen (s) + 1);
It's because it's used in gdb that the current code, before
Gary's patch has the #ifdef GDBSERVER #else /* gdb code */ bits.
He's just moving that code around.
Thanks,
Pedro Alves