This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Remove dwarf_decode_lines argumewant_line_info
- From: Doug Evans <dje at google dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 27 Aug 2014 11:59:04 -0700
- Subject: Re: [PATCH] Remove dwarf_decode_lines argumewant_line_info
- Authentication-results: sourceware.org; auth=none
- References: <1409129366-14108-1-git-send-email-yao at codesourcery dot com>
Yao Qi writes:
> Hi,
> dwarf_decode_lines is called in two functions,
> dwarf2_build_include_psymtabs and handle_DW_AT_stmt_list, in which, 1
> is passed to argument 'want_line_info' and 'want_line_info' is a
> conditional variable in dwarf_decode_lines. We can simplify it by
> removing 'want_line_info' and propagating the constant 1 into
> dwarf_decode_lines. This is what this patch does. This patch also
> remove one line comment about WANT_LINE_INFO in
> handle_DW_AT_stmt_list, as handle_DW_AT_stmt_list doesn't have such
> argument.
>
> gdb:
>
> 2014-08-27 Yao Qi <yao@codesourcery.com>
>
> * dwarf2read.c (dwarf_decode_lines): Update declaration.
> (handle_DW_AT_stmt_list): Remove comment about WANT_LINE_INFO.
> (dwarf_decode_lines): Remove argument
> want_line_info. Remove condition check on want_line_info.
> Callers update.
LGTM.
Thanks!