This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/6] Downgrade fatal to warning in linux_async
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 20 Aug 2014 17:18:07 +0100
- Subject: Re: [PATCH 3/6] Downgrade fatal to warning in linux_async
- Authentication-results: sourceware.org; auth=none
- References: <1407340688-13721-1-git-send-email-gbenson at redhat dot com> <1407340688-13721-4-git-send-email-gbenson at redhat dot com>
On 08/06/2014 04:58 PM, Gary Benson wrote:
> This commit downgrades a fatal error to a warning in linux_async.
> linux_async is called from two different places in gdbserver:
>
> Via target_async from handle_accept_event. The argument
> is always zero, so The warning will never be printed here
Typo "The" and period.
> Via start_non_stop from handle_general_set. This prints
> its own error message to stderr on failure, which will
> be preceded by the warning if it is emitted.
>
> gdb/gdbserver/
> 2014-08-06 Gary Benson <gbenson@redhat.com>
>
> * linux-low.c (linux_async): Replace fatal with warning.
> Tidy up and return.
> (linux_start_non_stop): Return -1 if linux_async failed.
This is OK.
Thanks,
Pedro Alves