This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/5 v7] Introduce common-debug.h
- From: "Frank Ch. Eigler" <fche at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: Mike Frysinger <vapier at gentoo dot org>, Steve Ellcey <sellcey at mips dot com>, Doug Evans <dje at google dot com>, gdb-patches <gdb-patches at sourceware dot org>, Pedro Alves <palves at redhat dot com>
- Date: Wed, 20 Aug 2014 09:31:55 -0400
- Subject: Re: [PATCH 4/5 v7] Introduce common-debug.h
- Authentication-results: sourceware.org; auth=none
- References: <20140819091220 dot GB6493 at blade dot nx> <1408490530 dot 31355 dot 15 dot camel at ubuntu-sellcey> <20140820085243 dot GA2694 at blade dot nx> <15329331 dot NicJ8HFAzI at vapier> <20140820120934 dot GA26854 at blade dot nx>
Hi -
> > [...]
> > i'm fine with updating sim/common/sim-trace.h with that idea:
> > #define debug_printf sim_debug_printf
> > all the symbols coming out of the sim really should be namespaced
IMHO, names this generic should be avoided in *both* application (gdb)
and library (sim), lest another future library come & interfere later.
> Great. I can put together a patch if you like (or I can make the
> change, or you can... whatever's easiest!) I don't know much about
> SIM... is there a list to mail patches to? And, is its upstream
> repo the same as binutils+GDB or is it imported from somewhere else
> like libiberty?
sim is part of the binutils-gdb.git repo, patches here fine. The main
problem with testing the sim for changes like this is its inability to
easily build all targets, and its aggressive use of macros, which
makes it hard to know you've actually covered all the cases for a
symbol-rename.
- FChE