This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Support _Complex in hard-VFP abi
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>, Will Newton <will dot newton at linaro dot org>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 19 Aug 2014 23:44:25 +0100
- Subject: Re: [PATCH] Support _Complex in hard-VFP abi
- Authentication-results: sourceware.org; auth=none
- References: <1407761487-9251-1-git-send-email-yao at codesourcery dot com> <CANu=Dmizt9SZmfLO=_yO6pwThFu+oAh8bbjPtXFAcmGDB+2amQ at mail dot gmail dot com> <53F34D56 dot 5050705 at codesourcery dot com>
On 08/19/2014 02:12 PM, Yao Qi wrote:
> On 08/11/2014 09:12 PM, Will Newton wrote:
>>>> + case TYPE_CODE_COMPLEX:
>>>> + /* Arguments of complex T where T is one of the types float or
>>>> + double get treated as if they are implemented as:
>>>> +
>>>> + struct complexT
>>>> + {
>>>> + T real;
>>>> + T imag;
>>>> + };*/
>> A line break before closing the comment might look nicer here.
>>
>
> I add two spaces before closing the comment, because we don't move
> "*/" to a separated line.
...
> + case TYPE_CODE_COMPLEX:
> + /* Arguments of complex T where T is one of the types float or
> + double get treated as if they are implemented as:
> +
> + struct complexT
> + {
> + T real;
> + T imag;
> + }; */
> + switch (TYPE_LENGTH (t))
This is borderline pedantry, but this looks ugly enough to me that
I'll speak up in case this ends up being the norm. :-) FWIW, I agree
with Will here -- I think we should make an exception to the rule
in the cases where the comment is actually a paste of output,
multiline code or similar cases. It's kind of like a @smallexample
region in texinfo, that begs to be rendered on its own block/lines,
separate from the text around it.
'grep -n "^[ |\t]\+\*/" *.h -B 3' finds several (many?) similar
examples (and a bunch of wrong-format comments too, though..)
<nit mode/>
Thanks,
Pedro Alves