This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[OB/PUSHED] Remove stale comment (was: Re: [PATCH] Set breakpoint on the right line)
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Tue, 19 Aug 2014 18:20:42 +0100
- Subject: [OB/PUSHED] Remove stale comment (was: Re: [PATCH] Set breakpoint on the right line)
- Authentication-results: sourceware.org; auth=none
- References: <1407806302-14295-1-git-send-email-yao at codesourcery dot com>
On 08/12/2014 02:18 AM, Yao Qi wrote:
>
> /* Stub lines are present as no breakpoints/watchpoint gets hit if current PC
> already stays on the line PC while entering "step"/"continue". */
I noticed that this comment is stale. This is no longer true for
watchpoints. I've pushed this as obvious.
-------------------------
Remove stale comment
This comment is no longer true for watchpoints since commit 31e77af2
(PR breakpoints/7143 - Watchpoint does not trigger when first set).
gdb/testsuite/
* gdb.base/watchpoint-hw-hit-once.c (main): Update comment.
---
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/gdb.base/watchpoint-hw-hit-once.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 060c7a1..d30f7a3 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2014-08-19 Pedro Alves <palves@redhat.com>
+
+ * gdb.base/watchpoint-hw-hit-once.c (main): Update comment.
+
2014-08-19 Yao Qi <yao@codesourcery.com>
* gdb.base/watchpoint-hw-hit-once.exp: Set breakpoint on the
diff --git a/gdb/testsuite/gdb.base/watchpoint-hw-hit-once.c b/gdb/testsuite/gdb.base/watchpoint-hw-hit-once.c
index 8ba8ca4..aa64f1d 100644
--- a/gdb/testsuite/gdb.base/watchpoint-hw-hit-once.c
+++ b/gdb/testsuite/gdb.base/watchpoint-hw-hit-once.c
@@ -22,7 +22,7 @@ main (void)
{
volatile int dummy;
- /* Stub lines are present as no breakpoints/watchpoint gets hit if current PC
+ /* Stub lines are present as no breakpoint gets hit if current PC
already stays on the line PC while entering "step"/"continue". */
dummy = 0; /* Stub to catch WATCHEE access after runto_main. */
--
1.9.3