Re: [PATCH] Typos in gdb/mi

[Simon Marchi <simon dot marchi at ericsson dot com>]

On 14-08-19 02:55 AM, Vladimir Prus wrote:
> On 08/18/2014 07:17 PM, Joel Brobecker wrote:
>>> I understand the motivation for making the change, and it does make
>>> the code better; thanks for taking the time!
>>>
>>> However, I was burned in past, when such cleanup patches caused merge
>>> problems for any local patches anybody might have. I wonder what
>>> others think?
>>
>> If it makes the code better, let's push it. It's not the contributor's
>> fault that other people's as-yet-unpushed patches may or may not collide.
>> If we have conflicting patches, their authors will just have to adjust,
>> as we often do when doing collaborative work on the same area of the code.
> 
> The question is whether combined price the community will pay for such
> adjustment is not greater than any improvements due to fixed typos.
> I'd be happy to go with your guidance, as far as GDB goes.
> 
> I've looked at the patch, and see nothing wrong. Simon, can you push it for
> Andreas?

The reason Andreas proposed this patch is actually to set up his account. He
has other patches in the pipeline that will require more discussion and back
& forth. We thought it would be a good idea for him to submit a small,
non-controversial patch to go through the account setup process.

Does it make sense?

> Thanks,
> Volodya
> 
>