This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch+7.8?] Fix --with-babeltrace with gcc-4.9.1


On Tue, 12 Aug 2014 22:32:55 +0200, Doug Evans wrote:
> E.g., can we just delete "pos" and the function call that initializes it?
> 
> struct bt_iter_pos *pos = bt_iter_get_pos (bt_ctf_get_iter (NULL));

I think we cannot and the reason is given in the comment there:
  # Append -Werror to CFLAGS so that configure can catch the warning
  # "assignment from incompatible pointer type", which is related to
  # the babeltrace change from 1.0.3 to 1.1.0.  Babeltrace 1.1.0 works
  # in GDB, while babeltrace 1.0.3 is broken.


> Or, if for some reason we need to test whether bf_ctf_get_iter exists,
> can we just
> call it and discard the result?

Also not due to the reason above.


Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]