This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Replace 0 with TARGET_XFER_EOF in to_xfer_partial
- From: Tom Tromey <tromey at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 06 Aug 2014 10:03:50 -0600
- Subject: Re: [PATCH] Replace 0 with TARGET_XFER_EOF in to_xfer_partial
- Authentication-results: sourceware.org; auth=none
- References: <1407306345-4371-1-git-send-email-yao at codesourcery dot com>
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> 'TARGET_XFER_EOF' (enum target_xfer_status) is expected to be returned,
Yao> but 0 is returned. This patch is to replace 0 with TARGET_XFER_EOF
Yao> in the implementations of to_xfer_partial. I'll commit it in two
Yao> days.
Looks good.
FWIW I think there should be a few more like this.
Maybe in ser-something.c?
And also this code in remote_xfer_partial:
/* Note: a zero OFFSET and LEN can be used to query the minimum
buffer size. */
if (offset == 0 && len == 0)
return (get_remote_packet_size ());
There's a bug filed for this one.
Tom