This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix PR 17206
- From: Yao Qi <yao at codesourcery dot com>
- To: Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Tue, 29 Jul 2014 14:36:42 +0800
- Subject: Re: [PATCH] Fix PR 17206
- Authentication-results: sourceware.org; auth=none
- References: <1406547056-22541-1-git-send-email-yao at codesourcery dot com> <53D6441B dot 3050702 at redhat dot com> <53D6511E dot 3040404 at codesourcery dot com> <53D65DA8 dot 1000005 at redhat dot com>
On 07/28/2014 10:26 PM, Pedro Alves wrote:
> From a high-level perspective, the issue triggered when you did
> "until" and PC pointed somewhere we had no debug info for, and there
> was no breakpoint at PC that needed to be stepped over. That is
> main use case and code path that we didn't have a test for.
>
> Note that although it happened to be a range-stepping-related assertion
> that triggered, the code was wrong even without range-stepping. E.g.,
> if the instruction at PC is a conditional jmp to PC (like a spinlock),
> even without range-stepping, "until" should continue stepping until
> PC moves past the jump (that's the whole point of until), while
> it was stopping after one single-step, thus still pointing at the
> same PC.
>
> So I think "until-nodebug.exp" would be a good name for this test.
That is OK to me. This bug is on 7.8 branch too. The patch is pushed
to mainline and 7.8 branch. I've added it to
https://sourceware.org/gdb/wiki/GDB_7.8_Release
--
Yao (éå)