Re: [PATCH 1/3 v4] Introduce common/errors.h

[Pedro Alves <palves at redhat dot com>]

On 07/25/2014 09:36 AM, Gary Benson wrote:

> I'm working on this now.  My plan is to have gdb/common/common-defs.h
> (which includes config.h and the correct gnulib config.h) and have
> defs.h and server.h include common-defs.h as the first line.  By the
> end of that series most every file will include defs.h or server.h
> and no file will include config.h.

I think you meant, that files in gdb will include defs.h, files in
gdbserver will include server.h, and files in the shared directories
will include common-defs.h as the first line.

> At the first instance common-defs.h will include most files included
> by both defs.h and server.h.  There are various workarounds for
> various things in both, and it would be good to have these workarounds
> the same for all of GDB/gdbserver/etc.  I plan to omit alloca.h and
> errno.h initially, as these have pretty heavy hacking around them and
> they're not needed yet.  I'll probably do both at some point, but as
> individual patches/serieses.
> 
> I'm also going to do some #include cleanups as part of the same
> series.  For example lots of things include common-utils.h, but
> that's currently included by defs.h and server.h (so I'll move it
> to common-defs.h) and if every file includes common-defs.h somehow
> then nothing needs common-utils.h.
> 
> Once the common-defs.h series is finished and pushed I'll rebase
> this common-cleanups series on top of it.  It'll be much cleaner
> and by then the number of "#ifdef GDBSERVER"s in the codebase
> will be precisely one (to select the appropriate gnulib config.h
> in common-defs.h).
> 
> Does all this sound ok?

It does to me.

-- 
Thanks,
Pedro Alves