This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Linux: Use kill_lwp/tkill instead of kill when killing a, process
- From: Pedro Alves <palves at redhat dot com>
- To: Stan Shebs <stanshebs at earthlink dot net>, gdb-patches at sourceware dot org
- Date: Wed, 16 Jul 2014 20:02:35 +0100
- Subject: Re: [PATCH] Linux: Use kill_lwp/tkill instead of kill when killing a, process
- Authentication-results: sourceware.org; auth=none
- References: <53C54C7C dot 3070907 at redhat dot com> <20140715192749 dot GA32218 at host2 dot jankratochvil dot net> <53C5948B dot 9000102 at earthlink dot net>
On 07/15/2014 08:27 PM, Jan Kratochvil wrote:
> I do not.
> Just it is the general GDB rule of "If it ain't broken, don't fix it".
> There are various old and patched kernels out there.
Well, it's broken, because it's not using tgkill, which we should be
using everywhere instead of tkill/kill. Leaving the place that sends
SIGKILL using plain "kill" is kind of self-defeating.
If there are NPTL kernels that require "kill" for some odd reason,
then we should add some kind of detection for that, so to not punish
newer kernels. LinuxThreads will always fallback to "kill".
On 07/15/2014 09:52 PM, Stan Shebs wrote:
> But going by context, maybe kill_lwp was just overlooked at
> the time, and then propagated verbatim thereafter.
Yes, that's my theory.
I'm pushing this in then.
--
Pedro Alves