This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 06/15] Remove simple GDBSERVER uses from common, nat and target
- From: Gary Benson <gbenson at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 15 Jul 2014 16:37:49 +0100
- Subject: Re: [PATCH 06/15] Remove simple GDBSERVER uses from common, nat and target
- Authentication-results: sourceware.org; auth=none
- References: <1404902255-11101-1-git-send-email-gbenson at redhat dot com> <1404902255-11101-7-git-send-email-gbenson at redhat dot com> <21444 dot 9684 dot 974497 dot 695609 at ruffy dot mtv dot corp dot google dot com>
Doug Evans wrote:
> Gary Benson writes:
> > This removes various simple GDBSERVER uses from common, nat and
> > target. The simple uses are just cases where the code includes defs.h
> > or server.h depending on GDBSERVER. Instead, now the files include
> > the headers that they require. Unfortunately we still need to check
> > GDBSERVER for some files to decide which gnulib config header to
> > import, but this is a step in the right direction.
[snip]
>
> LGTM, one nit:
>
> How about
>
> #include "config.h"
>
> instead of
>
> #include <config.h>
> ?
I've no objection with this, I'll make the change.
Thanks,
Gary
--
http://gbenson.net/