This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Report "No hardware breakpoint support" correctly
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Edjunior Barbosa Machado <emachado at linux dot vnet dot ibm dot com>
- Cc: gdb-patches at sourceware dot org, uweigand at de dot ibm dot com
- Date: Mon, 14 Jul 2014 09:13:08 -0700
- Subject: Re: [PATCH] Report "No hardware breakpoint support" correctly
- Authentication-results: sourceware.org; auth=none
- References: <1405349255-26782-1-git-send-email-emachado at linux dot vnet dot ibm dot com>
> gdb/
> 2014-07-14 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
>
> * gdb/ppc-linux-nat.c (ppc_linux_can_use_hw_breakpoint): Report no
> hardware breakpoint support correctly.
Just one itty bitty tiny little nit:
> ---
> gdb/ppc-linux-nat.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/gdb/ppc-linux-nat.c b/gdb/ppc-linux-nat.c
> index fcfd452..4c5d878 100644
> --- a/gdb/ppc-linux-nat.c
> +++ b/gdb/ppc-linux-nat.c
> @@ -1473,6 +1473,9 @@ ppc_linux_can_use_hw_breakpoint (struct target_ops *self,
> }
> else if (type == bp_hardware_breakpoint)
> {
> + if (total_hw_bp == 0)
> + /* No hardware breakpoint support. */
> + return 0;
Can you nest the contents of the if block inside curly braces.
We've decided a while ago that a comment looks visually like
a statement, and thus that comment + statement looks the same
as 2 statements, and thus normally requires curly braces...
Thanks!
--
Joel