This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 10/14] make dwarf_expr_frame_base_1 public
- From: Gary Benson <gbenson at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Mon, 23 Jun 2014 09:18:15 +0100
- Subject: Re: [PATCH v2 10/14] make dwarf_expr_frame_base_1 public
- Authentication-results: sourceware.org; auth=none
- References: <1403279874-23781-1-git-send-email-tromey at redhat dot com> <1403279874-23781-11-git-send-email-tromey at redhat dot com> <CADPb22SfYPSi+-hqaGm_Ru_9s8fgmW1TvHRjOansmZOtbi5fPQ at mail dot gmail dot com>
Doug Evans wrote:
> On Jun 20, 2014 6:33 PM, "Tom Tromey" <tromey@redhat.com> wrote:
> >
> > This exports dwarf_expr_frame_base_1 so that other code can use it.
> >
> > 2014-06-20 Tom Tromey <tromey@redhat.com>
> >
> > * dwarf2loc.h (dwarf_expr_frame_base_1): Declare.
> > * dwarf2loc.c (dwarf_expr_frame_base_1): Now public.
>
> [apologies for the repeat ... curse you gmail ...]
>
> Can you remove the _1?
> (renaming it as needed)
> I see the non _1 version is also static, so some reasonable renaming
> (perhaps of both) should be simple enough.
Is there some convention about what "_1" means in a function name?
Cheers,
Gary
--
http://gbenson.net/