This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] [patch] Fix --with-system-readline with readline-6.3 patch 5
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 20 Jun 2014 17:45:55 +0200
- Subject: [commit] [patch] Fix --with-system-readline with readline-6.3 patch 5
- Authentication-results: sourceware.org; auth=none
- References: <20140620105004 dot GA22236 at host2 dot jankratochvil dot net> <87d2e3acq4 dot fsf at fleche dot redhat dot com>
On Fri, 20 Jun 2014 16:15:47 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
>
> Jan> You also have to use system readline-6.3 including its upstream patch:
> Jan> [Bug-readline] Readline-6.3 Official Patch 5
> Jan> http://lists.gnu.org/archive/html/bug-readline/2014-04/msg00018.html
> Jan> Message-ID: <140415125618.AA57598.SM@caleb.ins.cwru.edu>
>
> What's the story with upgrading the in-tree readline?
IMO it should be done, checking the readline/ChangeLog.gdb changes etc.
Personally I find it valid only since readline-6.3 is in Fedora Rawhide now
as Fedora readline maintainer(s) had some issues with it before:
https://bugzilla.redhat.com/show_bug.cgi?id=1071336
> Jan> 2014-06-20 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Jan> Fix --with-system-readline with readline-6.3 patch 5.
> Jan> * tui/tui-io.c (tui_old_rl_getc_function, tui_old_rl_redisplay_function)
> Jan> (tui_old_rl_prep_terminal, tui_old_rl_deprep_terminal): Use rl_*_t
> Jan> types.
>
> Ok.
Checked in:
840ed64d1c1335328e0c4763dc5041d3cdb85c90
Jan