This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/4 v2] Refactor shared code in i386-{nat,low}.[ch]
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: palves at redhat dot com
- Cc: gbenson at redhat dot com, gdb-patches at sourceware dot org
- Date: Wed, 18 Jun 2014 19:48:22 +0200 (CEST)
- Subject: Re: [PATCH 0/4 v2] Refactor shared code in i386-{nat,low}.[ch]
- Authentication-results: sourceware.org; auth=none
- References: <1403104976-2492-1-git-send-email-gbenson at redhat dot com> <201406181606 dot s5IG6Mud000672 at glazunov dot sibelius dot xs4all dot nl> <53A1B9E8 dot 5010504 at redhat dot com>
> Date: Wed, 18 Jun 2014 17:10:16 +0100
> From: Pedro Alves <palves@redhat.com>
>
> On 06/18/2014 05:06 PM, Mark Kettenis wrote:
>
> > What is the whole point about this excercise?
>
> Reduce duplication and thus reduce maintenance burden. The same code is
> implemented twice, both in GDB and in GDBserver.
> We've had to patch both sides of the fence several times in the
> past years. If we had already had this, it would have saved effort.
> Can't rewrite history now, but we can avoid similar duplicate effort
> in the future. This specific bit is mentioned explicitly in:
>
> https://sourceware.org/gdb/wiki/Common#Arch-specific_bits_of_the_target_backends
But common code lives in common/, and this diff moves things into
nat/. How does that unduplicate things?