This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC][PATCH v2][PR remote/16896] Invalidate a register in cache when a remote target failed to write it.
- From: Pierre Langlois <pierre dot langlois at embecosm dot com>
- To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Thu, 12 Jun 2014 17:03:30 +0100
- Subject: Re: [RFC][PATCH v2][PR remote/16896] Invalidate a register in cache when a remote target failed to write it.
- Authentication-results: sourceware.org; auth=none
- References: <537E086A dot 9030803 at embecosm dot com> <5399A9CE dot 4040900 at redhat dot com>
Hi Pedro,
>> +}
>> +
>> +struct cleanup *
>> +make_cleanup_regcache_invalidate (struct regcache *regcache, int regnum)
>
> As nothing is calling this outside regcache.c, please make it static.
>
Should I exclude make_cleanup_regcache_invalidate from regcache.h as well in
this case?
Thank you for the review! And sorry for the formatting errors.
Best,
Pierre