This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/7] more constification
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>, gdb-patches at sourceware dot org
- Date: Thu, 12 Jun 2014 14:04:20 +0100
- Subject: Re: [PATCH 0/7] more constification
- Authentication-results: sourceware.org; auth=none
- References: <1402512797-6082-1-git-send-email-tromey at redhat dot com>
On 06/11/2014 07:53 PM, Tom Tromey wrote:
> This series constifies a few more things in gdb.
>
> A few of the patches are very basic and #4 is downright trivial.
>
> Patch #6 casts away const in a couple spots. There's a justification
> in the patch; but I also wanted to add that the casts only affect
> mdebugread.c, which can't really be said to be actively maintained in
> any case.
>
> Some of these patches are part of a larger work to constify the
> argument pass to gdb commands. This longer series isn't finished yet;
> but it simplifies to the work to put patches in bottom-up and mildly
> improves gdb in the process.
Looked fine to me.
A couple nits I noticed:
- The subject of patch #3 sounds like something you'd have
in a local branch. Should that patch be merged with some
other in the series? Does GDB build at each step of the
series?
- A typo in the log of patch #6: "SO".
--
Pedro Alves