This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Wrap PyObject_Get/HasAttrString in a function with second arg having const qualifier.
- From: Pedro Alves <palves at redhat dot com>
- To: Siva Chandra <sivachandra at google dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Cc: Ulrich Weigand <uweigand at de dot ibm dot com>
- Date: Mon, 09 Jun 2014 14:49:16 +0100
- Subject: Re: [PATCH] Wrap PyObject_Get/HasAttrString in a function with second arg having const qualifier.
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gzhoLC3DrxGqx+JaOZzydY4wJbh2zs9cwtN0508C_P26Q at mail dot gmail dot com>
On 06/09/2014 02:42 PM, Siva Chandra wrote:
> +/* The second argument to PyObject_GetAttrString was missing the 'const'
> + qualifier. Hence, we wrap it in a function to avoid errors when compiled
> + with -Werror against Python 2.4. */
I'd suggest moving the "in Python 2.4" to the first sentence, like:
/* The second argument to PyObject_GetAttrString was missing the 'const'
qualifier in Python 2.4. Hence, we wrap it in a function to avoid errors
when compiled with -Werror. */
Otherwise looks great to me.
Thanks!
--
Pedro Alves