This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [ping] [PATCH] Different outputs affected by locale
- From: Yao Qi <yao at codesourcery dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, Joel Brobecker <brobecker at adacore dot com>, <gdb-patches at sourceware dot org>
- Date: Thu, 5 Jun 2014 17:56:53 +0800
- Subject: Re: [ping] [PATCH] Different outputs affected by locale
- Authentication-results: sourceware.org; auth=none
- References: <1401192650-29688-1-git-send-email-yao at codesourcery dot com> <538EAEE5 dot 2080708 at codesourcery dot com> <20140604124708 dot GR4289 at adacore dot com> <538F1CC3 dot 9090605 at codesourcery dot com> <87oay8a0t6 dot fsf at fleche dot redhat dot com> <538F803A dot 9020007 at redhat dot com> <538FE412 dot 1050806 at codesourcery dot com> <53903119 dot 6000204 at redhat dot com>
On 06/05/2014 04:58 PM, Pedro Alves wrote:
>> This is a not a mingw issue nor a remote host testing issue.
> But that's a conflicting answer. It's a remote host testing
> if this only triggers with remote host testing.
>
OK, it is a remote host testing issue, since LC_CTYPE is set on build
only.
>> > If the
>> > LC_CTYPE isn't set properly on host, these tests will fail, even in the
>> > native testing.
> Sure, but it's supposed to be set, and then tests can assume so.
> If not set in some circumstance, then it's a bug in the test
> infrustruture, not the test. For native testing, those are
> set by gdb.exp:gdb_init.
>
>> >
>>> >> ssh)? Is LC_CTYPE really being propagated to the host?
>> >
>> > No, setting env variables on host or target in dejagnu isn't trivial to
>> > me.
> They need to be passed down explicitly in the ssh command line:
>
> $ ssh localhost "FOO=1 env | grep FOO"
> FOO=1
>
Yes, it is simple to pass env variable through ssh, but isn't trivial to
pass env variable to host or target in dejagnu, because,
- ssh is not the only connection dejagnu supports, how about telnet?
- env variable should bind to board. host and target can have
different env vars.
I saw Jie's patch to set env var on target
http://lists.gnu.org/archive/html/dejagnu/2008-07/msg00000.html
but we need do more than that, IMO. That is the reason I am inclined to
fix the test case instead of the infrastructure (dejagnu).
>> >
>>> >> Does testing GDB manually directly on a Windows console show the same
>>> >> issue?
>> >
>> > Yes, here is the output I got on Windows 7 (running gdb.exe in Windows console).
>> > However, I didn't investigate why 'Ã' is printed.
> But was that with LC_CTYPE set to C?
I don't know how check LC_CTYPE on Windows. :(
--
Yao (éå)