This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [ping] [PATCH] Different outputs affected by locale
- From: Tom Tromey <tromey at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: Joel Brobecker <brobecker at adacore dot com>, <gdb-patches at sourceware dot org>
- Date: Wed, 04 Jun 2014 14:15:33 -0600
- Subject: Re: [ping] [PATCH] Different outputs affected by locale
- Authentication-results: sourceware.org; auth=none
- References: <1401192650-29688-1-git-send-email-yao at codesourcery dot com> <538EAEE5 dot 2080708 at codesourcery dot com> <20140604124708 dot GR4289 at adacore dot com> <538F1CC3 dot 9090605 at codesourcery dot com>
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> The character printed by GDB in this case is out the control of GDB,
Yao> IMO. IOW, we can't tell what character printed is correct and what is
Yao> incorrect. Or we can relax the pattern to match either \242 or 'Â'
Yao> (cent sign) in the test. WDYT?
I think that would be preferable. It is more conservative for the
reason Joel pointed out; and should we encounter a system that emits
something else, it is easy to update the test at that time.
I am not really a great standards lawyer but my first reaction is that
mingw's C locale is not conforming. At least from:
http://pubs.opengroup.org/onlinepubs/009604499/basedefs/xbd_chap07.html
.. it seems to me that \242 is not defined as a 'print' character in the
LC_CTYPE section. Though I'd like to reiterate that I don't actually
trust my own reading of that text.
Tom