This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA v2] Make it easy to make --disable-werror the default for both binutils and gdb


> >   . Use "-a" instead of "&&" in the test expression; (H-P)
> 
>  I think Hans-Peter's suggestion was the other way round, its "&&" that is 
> portable while "-a" is likely not to work with non-GNU `test' or with 
> plain Bourne shells (where it is a builtin).  This is what the autoconf 
> manual has to say about it in its portability section:

Hmmm, I see. Thanks for theh clarification.

I propose the following: Keep the patch I propose as is for now, as it
does not make things worse, and also keep things consistent. And then
follow that up with a patch which switches the operators, all of them,
to using &&.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]