This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v5] Exit code of exited inferiors in -list-thread-groups


On 06/02/2014 09:20 PM, Simon Marchi wrote:
>> > keeping things octal, for consistency with what the user sees in the
>> > console.
> I had forgotten that the exit-code was already displayed somewhere else in the MI. Indeed,
> having the same field in different formats in different records would make a very bad interface.
> 
> Speaking of which, the documentation for the *stopped record does not mention exit-code at
> all. I think it should, since it appears in it when the exit code is not 0.

Yeah.  It only appears in an example of -exec-run:

 @smallexample
 (gdb)
 -exec-run
 ^running
 (gdb)
 x = 55
 *stopped,reason="exited",exit-code="01"
 (gdb)
 @end smallexample

> 
>> > (Note you had missed updating at least one example in the manual.)
> I am not sure I understand. The examples in the -list-thread-groups command section? If so, I
> believe they should not contain a exit-code field, as the process is running.

I meant the -exec-run example above.  But that was kind of me getting
confused, as the patch doesn't change the output in that case.  So read
that as me pointing out a place in the manual where we show the result
in octal, that would need updating if we ever want to change the
output format consistently.  :-)

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]