This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/4 v19] Add support for lookup, overload resolution and invocation of xmethods of C++ classes
- From: Doug Evans <xdje42 at gmail dot com>
- To: Siva Chandra <sivachandra at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Sun, 01 Jun 2014 21:04:14 -0700
- Subject: Re: [PATCH 3/4 v19] Add support for lookup, overload resolution and invocation of xmethods of C++ classes
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gx1fP+6UFFcgt+4V=U0gVks6k4uQYHBAV4VzS=sbbrRLQ at mail dot gmail dot com>
Siva Chandra <sivachandra@google.com> writes:
> No changes from v18.
>
> ChangeLog
>
> 2014-05-30 Siva Chandra Reddy <sivachandra@google.com>
>
> * eval.c (evaluate_subexp_standard): Call the xmethod if the
> best match method returned by find_overload_match is an xmethod.
> * valarith.c (value_x_binop, value_x_unop): Call the xmethod if
> the best matching operator returned by find_overload_match is an
> xmethod.
> * valops.c: #include "extension.h".
> (find_method_list): Add "fn_list" and "xm_worker_vec" arguments.
> Return void. The list of matching source methods is returned in
> "fn_list" and a vector of matching debug method workers is
> returned in "xm_worker_vec". Update all callers.
> (value_find_oload_method_list): Likewise.
> (find_oload_champ): Add "xm_worker_vec" parameter. If it is
> non-NULL, then the index of the best matching method in this
> vector is returned. Update all callers.
> (find_overload_match): Include xmethods while performing overload
> resolution.
LGTM