This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb/source.c: Fix source path substitution
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Brad Mouring <bmouring at ni dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 28 May 2014 09:15:31 -0700
- Subject: Re: [PATCH] gdb/source.c: Fix source path substitution
- Authentication-results: sourceware.org; auth=none
- References: <1400878971-6311-1-git-send-email-brad dot mouring at ni dot com> <20140523234959 dot GX22822 at adacore dot com> <20140524000034 dot GY22822 at adacore dot com> <20140527131716 dot GA8300 at linuxgetsreal> <20140527181033 dot GA3357 at adacore dot com> <20140528160120 dot GA32338 at linuxgetsreal>
> > > Will do. I take it this info belongs in the commit message, or would
> > > you rather it be a cover letter-type email?
> >
> > Can you explain which info you are referring to?
> The details concerning the issue that I'm fixing
Generally speaking, the best place for explaining why you do what
you do is the code. The more goes into the code, the better (usually).
The rest should be in the revision log. The idea is to help us avoid
doing most of the archeology based purely on the repository. Tracking
emails is quite a bit more labor-intensive...
For an example of a commit that I thought was pretty nice, take a look at:
commit 6a3cb8e88a739c967bb9b2d8774bf96b87a7fda4
Author: Pedro Alves <palves@redhat.com>
Date: Wed May 21 18:30:47 2014 +0100
Allow making GDB not automatically connect to the native target.
It provides the context, shows what we had before, what we get now,
motivation, etc.
> One additional question that I had that was not answered on the IRC
> channel is I wanted some validation that such a simple change does
> not require copyright assignment since this fixes existing functionality
> and provides no new, patentable functionality.
If you keep your contributions to obvious changes, and/or small ones,
they are deemed "not legally significant", and we can accept one
or two of them. The guideline is that it should be under 15 lines.
--
Joel