This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb/source.c: Fix source path substitution
- From: "Brad Mouring" <bmouring at ni dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Brad Mouring <bmouring at ni dot com>, gdb-patches at sourceware dot org
- Date: Wed, 28 May 2014 11:01:20 -0500
- Subject: Re: [PATCH] gdb/source.c: Fix source path substitution
- Authentication-results: sourceware.org; auth=none
- References: <1400878971-6311-1-git-send-email-brad dot mouring at ni dot com> <20140523234959 dot GX22822 at adacore dot com> <20140524000034 dot GY22822 at adacore dot com> <20140527131716 dot GA8300 at linuxgetsreal> <20140527181033 dot GA3357 at adacore dot com>
On Tue, May 27, 2014 at 11:10:33AM -0700, Joel Brobecker wrote:
> > > > First of all, the administrative stuff. There are a few important pieces
> > > > missing from your subscription. I invite you read the file gdb/CONTRIBUTE
> > > > which should explain it all. Do not hesitate to ask questions if needed.
> >
> > Will do. I take it this info belongs in the commit message, or would
> > you rather it be a cover letter-type email?
>
> Can you explain which info you are referring to?
The details concerning the issue that I'm fixing
>
> About cover letters, they typically seem to be used when submitting
> a series of patch, rather than a patch alone, to introduce the series,
> or to provide info that really does not belong in the revision log,
> Other than that, having the details in the revision log is usually
> mostly positive, but we can help you with our review if we think
> we can help improving it.
>
> --
> Joel
One additional question that I had that was not answered on the IRC
channel is I wanted some validation that such a simple change does
not require copyright assignment since this fixes existing functionality
and provides no new, patentable functionality.
-Brad